lkml.org 
[lkml]   [2021]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] drivers/firmware: consolidate EFI framebuffer setup for all arches
Date
Hi

Am 21.05.21 um 21:37 schrieb Javier Martinez Canillas:
> The register_gop_device() function registers an "efi-framebuffer" platform
> device to match against the efifb driver, to have an early framebuffer for
> EFI platforms.
>
> But the Generic System Framebuffers (sysfb) already has support for this.
>
> Instead of having duplicated logic for x86 and other architectures using
> EFI, consolidate the two in sysfb and remove it from the EFI init logic.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
>
> arch/arm/Kconfig | 1 +
> arch/arm/include/asm/efi.h | 5 +-
> arch/arm64/Kconfig | 1 +
> arch/arm64/include/asm/efi.h | 5 +-
> arch/riscv/Kconfig | 1 +
> arch/riscv/include/asm/efi.h | 5 +-
> drivers/firmware/Kconfig | 7 ++-
> drivers/firmware/Makefile | 2 +-
> drivers/firmware/efi/efi-init.c | 90 -------------------------------
> drivers/firmware/efi/sysfb_efi.c | 77 +++++++++++++++++++++++++-
> drivers/firmware/sysfb.c | 40 +++++++++-----
> drivers/firmware/sysfb_simplefb.c | 29 ++++++----
> include/linux/sysfb.h | 28 +++++-----
> 13 files changed, 145 insertions(+), 146 deletions(-)
>
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 24804f11302..30ba195ca72 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -127,6 +127,7 @@ config ARM
> select PERF_USE_VMALLOC
> select RTC_LIB
> select SET_FS
> + select SYSFB

Don't select this as part of the architecture. Rather make an option for
SYSFB that depends in the architectures that supports it.

Best regards
Thomas


--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-05-22 07:14    [W:0.445 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site