Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 21 May 2021 13:09:37 +0300 | Subject | Re: [PATCH v2 1/3] gpio: regmap: Support few IC specific operations |
| |
On Fri, May 21, 2021 at 12:53 PM Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> wrote: > > The set_config and init_valid_mask GPIO operations are usually very IC > specific. Allow IC drivers to provide these custom operations at > gpio-regmap registration.
Thanks for this. In general (from design p.o.v.) looks good to me, one question below, though.
> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > > --- > Changelog v2: (based on suggestions by Michael Walle) > - drop gpio_regmap_set_drvdata()
But why do we have gpio_regmap_get_drvdata() and why is it different now to the new member handling?
> - drop checks and WARN() for pretty much impossible cases
-- With Best Regards, Andy Shevchenko
| |