lkml.org 
[lkml]   [2021]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/3] gpio: regmap: Support few IC specific operations
    Am 2021-05-21 12:09, schrieb Andy Shevchenko:
    > On Fri, May 21, 2021 at 12:53 PM Matti Vaittinen
    > <matti.vaittinen@fi.rohmeurope.com> wrote:
    >> Changelog v2: (based on suggestions by Michael Walle)
    >> - drop gpio_regmap_set_drvdata()
    >
    > But why do we have gpio_regmap_get_drvdata() and why is it different
    > now to the new member handling?

    Eg. the reg_mask_xlate() callback is just passed a "struct
    gpio_regmap*".
    If someone needs to access private data there, gpio_regmap_get_drvdata()
    is used. At least that was its intention.

    Thus I was also suggesting to use "struct gpio_regmap*" in the newer
    callbacks.

    I don't get what you mean by "different to the new member handling"?

    -michael

    \
     
     \ /
      Last update: 2021-05-21 12:20    [W:2.933 / U:0.700 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site