lkml.org 
[lkml]   [2021]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v1 0/3] fpga: Use standard class dev_release function
Date
The FPGA framework has a convention of using managed resource
functions to allow parent drivers to manage the data structures
allocated by the class drivers. They use an empty *_dev_release()
function to satisfy the class driver.

This is inconsistent with linux driver model.

These changes remove the managed resource functions and populate
the class dev_release callback functions. They also merge the
create and register functions into a single register function for
each of the fpga-mgr, fpga-region, and fpga-bridge class drivers.

For more context, refer to this email thread:

https://marc.info/?l=linux-fpga&m=162127412218557&w=2

I turned on the configs assocated with each of the modified files,
but I must have been missing some dependencies, because not all
of them compiled. I did a run-time test specifically with the
dfl-fme infrastructure. This would have exercised the region,
bridge, and fpga-mgr frameworks.

- Russ

Russ Weight (3):
fpga: mgr: Use standard dev_release for class driver
fpga: bridge: Use standard dev_release for class driver
fpga: region: Use standard dev_release for class driver

drivers/fpga/altera-cvp.c | 12 +-
drivers/fpga/altera-fpga2sdram.c | 12 +-
drivers/fpga/altera-freeze-bridge.c | 10 +-
drivers/fpga/altera-hps2fpga.c | 12 +-
drivers/fpga/altera-pr-ip-core.c | 6 +-
drivers/fpga/altera-ps-spi.c | 8 +-
drivers/fpga/dfl-fme-br.c | 10 +-
drivers/fpga/dfl-fme-mgr.c | 10 +-
drivers/fpga/dfl-fme-region.c | 10 +-
drivers/fpga/dfl.c | 10 +-
drivers/fpga/fpga-bridge.c | 113 ++++--------------
drivers/fpga/fpga-mgr.c | 177 ++++------------------------
drivers/fpga/fpga-region.c | 97 +++------------
drivers/fpga/ice40-spi.c | 8 +-
drivers/fpga/machxo2-spi.c | 8 +-
drivers/fpga/of-fpga-region.c | 10 +-
drivers/fpga/socfpga-a10.c | 16 +--
drivers/fpga/socfpga.c | 8 +-
drivers/fpga/stratix10-soc.c | 15 +--
drivers/fpga/ts73xx-fpga.c | 8 +-
drivers/fpga/xilinx-pr-decoupler.c | 17 +--
drivers/fpga/xilinx-spi.c | 10 +-
drivers/fpga/zynq-fpga.c | 16 +--
drivers/fpga/zynqmp-fpga.c | 8 +-
include/linux/fpga/fpga-bridge.h | 12 +-
include/linux/fpga/fpga-mgr.h | 14 +--
include/linux/fpga/fpga-region.h | 12 +-
27 files changed, 150 insertions(+), 499 deletions(-)

--
2.25.1

\
 
 \ /
  Last update: 2021-05-21 03:05    [W:0.061 / U:1.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site