Messages in this thread | | | Date | Mon, 17 May 2021 08:20:18 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 5/6] [v2] asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user |
| |
On Sat, May 15, 2021 at 12:18:02PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Consolidate the asm-generic implementation with the library version > that is used everywhere else. > > These are the three versions for NOMMU kernels,
I don't get the three versions part?
> + select GENERIC_STRNCPY_FROM_USER > + select GENERIC_STRNLEN_USER
Given that most architetures select the generic version I wonder if it might be worth to add another patch to invert the logic so that architectures with their own implementation need to sekect a symbol.
> +extern long strncpy_from_user(char *dst, const char __user *src, long count); > +extern long strnlen_user(const char __user *src, long n);
No need for the extern here.
| |