Messages in this thread |  | | From | Arnd Bergmann <> | Subject | [PATCH 0/6] [v2] asm-generic: strncpy_from_user/strnlen_user cleanup | Date | Sat, 15 May 2021 12:17:57 +0200 |
| |
From: Arnd Bergmann <arnd@arndb.de>
As I've queued up some patches for asm-generic, I remembered an older series that I created but never submitted.
These two functions appear to be unnecessarily different between architectures, and the asm-generic version is a bit questionable, even for NOMMU architectures.
Clean this up to just use the generic library version for anything that uses the generic version today. I've expanded on the patch descriptions a little, as suggested by Christoph Hellwig, but I suspect a more detailed review would uncover additional problems with the custom versions that are getting removed.
Arnd
Arnd Bergmann (6): [v2] asm-generic/uaccess.h: remove __strncpy_from_user/__strnlen_user [v2] h8300: remove stale strncpy_from_user [v2] hexagon: use generic strncpy/strnlen from_user [v2] arc: use generic strncpy/strnlen from_user [v2] asm-generic: uaccess: remove inline strncpy_from_user/strnlen_user [v2] asm-generic: remove extra strn{cpy_from,len}_user declarations
arch/arc/Kconfig | 2 + arch/arc/include/asm/uaccess.h | 72 ---------------- arch/arc/mm/extable.c | 12 --- arch/h8300/Kconfig | 2 + arch/h8300/kernel/h8300_ksyms.c | 2 - arch/h8300/lib/Makefile | 2 +- arch/h8300/lib/strncpy.S | 35 -------- arch/hexagon/Kconfig | 2 + arch/hexagon/include/asm/uaccess.h | 31 ------- arch/hexagon/kernel/hexagon_ksyms.c | 1 - arch/hexagon/mm/Makefile | 2 +- arch/hexagon/mm/strnlen_user.S | 126 ---------------------------- arch/m68k/Kconfig | 4 +- arch/riscv/Kconfig | 4 +- arch/um/include/asm/uaccess.h | 5 +- arch/um/kernel/skas/uaccess.c | 5 +- include/asm-generic/uaccess.h | 52 ++---------- 17 files changed, 25 insertions(+), 334 deletions(-) delete mode 100644 arch/h8300/lib/strncpy.S delete mode 100644 arch/hexagon/mm/strnlen_user.S
-- 2.29.2
Cc: Christoph Hellwig <hch@lst.de> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Vineet Gupta <vgupta@synopsys.com> Cc: Yoshinori Sato <ysato@users.sourceforge.jp> Cc: Brian Cain <bcain@codeaurora.org> Cc: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Paul Walmsley <paul.walmsley@sifive.com> Cc: Palmer Dabbelt <palmer@dabbelt.com> Cc: Albert Ou <aou@eecs.berkeley.edu> Cc: Jeff Dike <jdike@addtoit.com> Cc: Richard Weinberger <richard@nod.at> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Sid Manning <sidneym@codeaurora.org> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Mike Rapoport <rppt@kernel.org> Cc: linux-snps-arc@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: uclinux-h8-devel@lists.sourceforge.jp Cc: linux-hexagon@vger.kernel.org Cc: linux-m68k@lists.linux-m68k.org Cc: linux-riscv@lists.infradead.org Cc: linux-um@lists.infradead.org Cc: linux-arch@vger.kernel.org
|  |