[lkml]   [2021]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: hwmon: (pcf8591) Unused attribute group pcf8591_attr_group_opt
On 5/15/21 6:20 AM, Evgeny Novikov wrote:
> Driver drivers/hwmon/pcf8591.ko declares and removes attribute group
> pcf8591_attr_group_opt, but it does not create it ever. Is it better to remove
> it completely or to do something else?

Do nothing. Look closely at the file instead to see how the attributes
are created, and realize that the group is only used to simplify
attribute removal.

Yes, the code is a bit odd and unusual, but it is WAI.


 \ /
  Last update: 2021-05-15 15:45    [W:0.031 / U:1.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site