Messages in this thread | | | Date | Fri, 14 May 2021 17:41:33 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH v3] net: phy: add driver for Motorcomm yt8511 phy |
| |
> Good Catch! > > Guess I'll have to set that too, anything else you'd recommend looking into?
I think for a first submission, you have the basics. I'm just pushing RGMII delays because we have had backwards compatibility problems in that area when added later. Experience suggests adding features in other areas is much less of a problem. So as you suggested, you can add cable test, downshift control, interrupts etc later.
Andrew
| |