Messages in this thread | | | From | Arnd Bergmann <> | Date | Fri, 14 May 2021 17:28:57 +0200 | Subject | Re: [PATCH] kcsan: fix debugfs initcall return type |
| |
On Fri, May 14, 2021 at 4:45 PM 'Marco Elver' via Clang Built Linux <clang-built-linux@googlegroups.com> wrote: > On Fri, 14 May 2021 at 16:10, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > On Fri, May 14, 2021 at 04:00:08PM +0200, Arnd Bergmann wrote: > > > From: Arnd Bergmann <arnd@arndb.de> > > > > > > clang points out that an initcall funciton should return an 'int': > > > > > > kernel/kcsan/debugfs.c:274:15: error: returning 'void' from a function with incompatible result type 'int' > > > late_initcall(kcsan_debugfs_init); > > > ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ > > > include/linux/init.h:292:46: note: expanded from macro 'late_initcall' > > > #define late_initcall(fn) __define_initcall(fn, 7) > > > > > > Fixes: e36299efe7d7 ("kcsan, debugfs: Move debugfs file creation out of early init") > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > [...] > > > > > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Reviewed-by: Marco Elver <elver@google.com> > > Thanks for catching this -- it boggles my mind why gcc nor clang > wouldn't warn about this by default... > Is this a new clang?
It was clang-13, not sure if that made a difference.
Arnd
| |