Messages in this thread | | | Date | Fri, 14 May 2021 16:10:30 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] kcsan: fix debugfs initcall return type |
| |
On Fri, May 14, 2021 at 04:00:08PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > clang points out that an initcall funciton should return an 'int': > > kernel/kcsan/debugfs.c:274:15: error: returning 'void' from a function with incompatible result type 'int' > late_initcall(kcsan_debugfs_init); > ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~ > include/linux/init.h:292:46: note: expanded from macro 'late_initcall' > #define late_initcall(fn) __define_initcall(fn, 7) > > Fixes: e36299efe7d7 ("kcsan, debugfs: Move debugfs file creation out of early init") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > kernel/kcsan/debugfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/kernel/kcsan/debugfs.c b/kernel/kcsan/debugfs.c > index c1dd02f3be8b..e65de172ccf7 100644 > --- a/kernel/kcsan/debugfs.c > +++ b/kernel/kcsan/debugfs.c > @@ -266,9 +266,10 @@ static const struct file_operations debugfs_ops = > .release = single_release > }; > > -static void __init kcsan_debugfs_init(void) > +static int __init kcsan_debugfs_init(void) > { > debugfs_create_file("kcsan", 0644, NULL, NULL, &debugfs_ops); > + return 0; > } > > late_initcall(kcsan_debugfs_init); > -- > 2.29.2 > Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| |