Messages in this thread | | | From | Thomas Tai <> | Subject | RE: [PATCH 1/2] x86/traps: call cond_local_irq_disable before returning from exc_general_protection and math_error | Date | Fri, 9 Apr 2021 13:08:55 +0000 |
| |
> -----Original Message----- > From: Alexandre CHARTRE <alexandre.chartre@oracle.com> > Sent: April 9, 2021 5:06 AM > To: Thomas Tai <thomas.tai@oracle.com>; tglx@linutronix.de; > mingo@redhat.com; bp@alien8.de; x86@kernel.org > Cc: sean.j.christopherson@intel.com; luto@amacapital.net; > jarkko@kernel.org; bp@suse.de; jethro@fortanix.com; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH 1/2] x86/traps: call cond_local_irq_disable before > returning from exc_general_protection and math_error > > > On 4/8/21 7:28 PM, Thomas Tai wrote: > > This fixes commit 334872a09198 ("x86/traps: Attempt to fixup > exceptions > > in vDSO before signaling") which added return statements without > calling > > cond_local_irq_disable(). According to commit ca4c6a9858c2 > > ("x86/traps: Make interrupt enable/disable symmetric in C code"), > > cond_local_irq_disable() is needed because the ASM return code no > > longer disables interrupts. Follow the existing code as an example to > > use "goto exit" instead of "return" statement. > > > > Signed-off-by: Thomas Tai <thomas.tai@oracle.com> > > --- > > arch/x86/kernel/traps.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>
Thank you Alex.
Thomas
> > And it is probably worth adding a 'Fixes:' tag: > > Fixes: 334872a09198 ("x86/traps: Attempt to fixup exceptions in vDSO > before signaling") > > alex.
| |