lkml.org 
[lkml]   [2021]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/2] x86/traps: call cond_local_irq_disable before returning from exc_general_protection and math_error
Date
> -----Original Message-----
> From: Alexandre CHARTRE <alexandre.chartre@oracle.com>
> Sent: April 9, 2021 5:06 AM
> To: Thomas Tai <thomas.tai@oracle.com>; tglx@linutronix.de;
> mingo@redhat.com; bp@alien8.de; x86@kernel.org
> Cc: sean.j.christopherson@intel.com; luto@amacapital.net;
> jarkko@kernel.org; bp@suse.de; jethro@fortanix.com; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 1/2] x86/traps: call cond_local_irq_disable before
> returning from exc_general_protection and math_error
>
>
> On 4/8/21 7:28 PM, Thomas Tai wrote:
> > This fixes commit 334872a09198 ("x86/traps: Attempt to fixup
> exceptions
> > in vDSO before signaling") which added return statements without
> calling
> > cond_local_irq_disable(). According to commit ca4c6a9858c2
> > ("x86/traps: Make interrupt enable/disable symmetric in C code"),
> > cond_local_irq_disable() is needed because the ASM return code no
> > longer disables interrupts. Follow the existing code as an example to
> > use "goto exit" instead of "return" statement.
> >
> > Signed-off-by: Thomas Tai <thomas.tai@oracle.com>
> > ---
> > arch/x86/kernel/traps.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
> Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>

Thank you Alex.

Thomas

>
> And it is probably worth adding a 'Fixes:' tag:
>
> Fixes: 334872a09198 ("x86/traps: Attempt to fixup exceptions in vDSO
> before signaling")
>
> alex.
\
 
 \ /
  Last update: 2021-04-09 15:10    [W:0.061 / U:2.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site