Messages in this thread | | | Subject | Re: [PATCH 1/2] x86/traps: call cond_local_irq_disable before returning from exc_general_protection and math_error | From | Alexandre Chartre <> | Date | Fri, 9 Apr 2021 11:06:16 +0200 |
| |
On 4/8/21 7:28 PM, Thomas Tai wrote: > This fixes commit 334872a09198 ("x86/traps: Attempt to fixup exceptions > in vDSO before signaling") which added return statements without calling > cond_local_irq_disable(). According to commit ca4c6a9858c2 > ("x86/traps: Make interrupt enable/disable symmetric in C code"), > cond_local_irq_disable() is needed because the ASM return code no > longer disables interrupts. Follow the existing code as an example to > use "goto exit" instead of "return" statement. > > Signed-off-by: Thomas Tai <thomas.tai@oracle.com> > --- > arch/x86/kernel/traps.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Alexandre Chartre <alexandre.chartre@oracle.com>
And it is probably worth adding a 'Fixes:' tag:
Fixes: 334872a09198 ("x86/traps: Attempt to fixup exceptions in vDSO before signaling")
alex.
| |