Messages in this thread | | | Subject | Re: [Outreachy kernel][PATCH] staging: media: hantro: Rewrite macro function in lower case | From | Ezequiel Garcia <> | Date | Fri, 09 Apr 2021 14:42:02 -0300 |
| |
On Fri, 2021-04-09 at 19:25 +0200, Julia Lawall wrote: > > > On Fri, 9 Apr 2021, ascordeiro wrote: > > > Em sex, 2021-04-09 às 13:44 -0300, Ezequiel Garcia escreveu: > > > Hi Aline, > > > > Hi Ezequiel, > > > > > > On Fri, 2021-04-09 at 10:54 -0300, Aline Santana Cordeiro wrote: > > > > Rewrite macros resembling functions #define HANTRO_PP_REG_WRITE > > > > and #define HANTRO_PP_RED_WRITE_S in lower case, according with > > > > code style. > > Maybe you can see if these macros can be converted to static inline > functions. Macros don't provide any type checking. >
I'd like to leave these as they are for now, tbh ^_^
A more massive refactoring is needed in this driver, but it needs proper testing and it's a more complex plan.
Thanks! Ezequiel
| |