lkml.org 
[lkml]   [2021]   [Apr]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Outreachy kernel][PATCH] staging: media: hantro: Rewrite macro function in lower case
From
Date
On Fri, 2021-04-09 at 19:25 +0200, Julia Lawall wrote:
>
>
> On Fri, 9 Apr 2021, ascordeiro wrote:
>
> > Em sex, 2021-04-09 às 13:44 -0300, Ezequiel Garcia escreveu:
> > > Hi Aline,
> >
> > Hi Ezequiel,
> > >
> > > On Fri, 2021-04-09 at 10:54 -0300, Aline Santana Cordeiro wrote:
> > > > Rewrite macros resembling functions #define HANTRO_PP_REG_WRITE
> > > > and #define HANTRO_PP_RED_WRITE_S in lower case, according with
> > > > code style.
>
> Maybe you can see if these macros can be converted to static inline
> functions.  Macros don't provide any type checking.
>

I'd like to leave these as they are for now, tbh ^_^

A more massive refactoring is needed in this driver,
but it needs proper testing and it's a more complex plan.

Thanks!
Ezequiel

\
 
 \ /
  Last update: 2021-04-09 19:42    [W:0.060 / U:0.376 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site