Messages in this thread | | | Subject | Re: [Outreachy kernel][PATCH] staging: media: hantro: Rewrite macro function in lower case | From | Ezequiel Garcia <> | Date | Fri, 09 Apr 2021 14:15:56 -0300 |
| |
On Fri, 2021-04-09 at 14:00 -0300, ascordeiro wrote: > Em sex, 2021-04-09 às 13:44 -0300, Ezequiel Garcia escreveu: > > Hi Aline, > > Hi Ezequiel, > > > > On Fri, 2021-04-09 at 10:54 -0300, Aline Santana Cordeiro wrote: > > > Rewrite macros resembling functions #define HANTRO_PP_REG_WRITE > > > and #define HANTRO_PP_RED_WRITE_S in lower case, according with > > > code style. > > > > > > > Where is this written in the Coding Style? > > I found this in section 12, about Macros, Enums and RTL in both > references: > https://www.kernel.org/doc/html/latest/process/coding-style.html > https://elixir.bootlin.com/linux/latest/source/Documentation/process/coding-style.rst
It seems this
""" CAPITALIZED macro names are appreciated but macros resembling functions may be named in lower case. """
It's just a suggestion, not a big deal. In general, if checkpatch.pl is not complaining, it's not worth the trouble.
So let's skip this fix.
Thanks a lot! Ezequiel
| |