Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Thu, 8 Apr 2021 16:15:37 +0200 | Subject | Re: [PATCH v2 1/6] software node: Free resources explicitly when swnode_register() fails |
| |
On Wed, Mar 31, 2021 at 1:06 PM Heikki Krogerus <heikki.krogerus@linux.intel.com> wrote: > > On Mon, Mar 29, 2021 at 06:12:02PM +0300, Andy Shevchenko wrote: > > Currently we have a slightly twisted logic in swnode_register(). > > It frees resources that it doesn't allocate on error path and > > in once case it relies on the ->release() implementation. > > > > Untwist the logic by freeing resources explicitly when swnode_register() > > fails. Currently it happens only in fwnode_create_software_node(). > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > It all looks OK to me. FWIW, for the whole series: > > Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Whole series applied (with some minor changelog edits) as 5.13 material, thanks!
| |