Messages in this thread | | | Subject | Re: [PATCH v2 5/6] software node: Introduce SOFTWARE_NODE_REFERENCE() helper macro | From | Daniel Scally <> | Date | Wed, 31 Mar 2021 12:25:51 +0100 |
| |
Hi Andy
On 30/03/2021 10:26, Andy Shevchenko wrote: >>> + { .pointer = &SOFTWARE_NODE_REFERENCE(_ref_, ##__VA_ARGS__), }, \ >> What are the .args intended to be used for? I actually had it in mind to >> replace this with a simple pointer to a struct software_node, because I >> can't see any users of them and the fact that it's actually storing a >> pointer to a new variable is something that confused me for a good long >> time when I wrote the cio2-bridge (though that's mostly due to my >> relative inexperience of course, but still) > It's to be in align with DT phandle references that can take arguments. While > for now, indeed, we have no users of this, it might be changed in the future > (I hadn't checked DesignWare DMA where I would like to transform the code to > use device properties eventually and there it might be the case).
Ah yeah I see - haven't come across phandles before but having looked them up now I see what this is meant to emulate. Consistency is good; in that case, for this and 6/6:
Reviewed-by: Daniel Scally <djrscally@gmail.com>
and
Tested-by: Daniel Scally <djrscally@gmail.com>
>
| |