lkml.org 
[lkml]   [2021]   [Apr]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] pwm: visconti: Add Toshiba Visconti SoC PWM support
Hello Nobuhiro,

On Thu, Apr 08, 2021 at 08:15:48AM +0900, Nobuhiro Iwamatsu wrote:
> > > + /*
> > > + * pwmc is a 2-bit divider for the input clock running at 1 MHz.
> > > + * When the settings of the PWM are modified, the new values are shadowed in hardware until
> > > + * the period register (PCSR) is written and the currently running period is completed. This
> > > + * way the hardware switches atomically from the old setting to the new.
> > > + * Also, disabling the hardware completes the currently running period and keeps the output
> > > + * at low level at all times.
> >
> > Did you just copy my optimal description or is your hardware really that
> > nice?
>
> Yes, this hardware works as you wrote.
> And I added about the state if the sinnal when this hardware disabled.
>
> >
> > Do you know scripts/checkpatch.pl? I bet it will tell you to limit your
> > lines to approx. 80 chars where sensible.
>
> Yes, I know. I ran scripts/checkpatch.pl before send patch.
> I understand that the number of characters per line has been changed to
> 100 characters. Does the pwm driver recommend 80 characters?

For free-text comments I'd still recommend 80, yes. For code lines I'd
be indeed more lax, as a line break in function calls reduces readability.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-04-08 10:00    [W:0.053 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site