lkml.org 
[lkml]   [2021]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/9] Cleaning up some of the irqdomain features
Date
The irqdomain subsystem has grown quite a lot over the years, and some
of its features are either oddly used or just pretty useless. Some
other helpers expose internals that are likely to change soon.

Here are the bits that I'm trying to get rid of:

- irq_linear_revmap exposes the internals of the domains, and only
works for linear domains. The supposed speed improvement really
isn't an argument, as it gets in the way of more significant
optimisations. Reimplemented in terms of irq_find_mapping, which
always works, and will eventually go at some point.

- irq_create_strict_mappings is just a way to constraint the
allocation of irqdescs into a given range, which is better served by
creating a legacy irqdomain, and shows that the platform really
needs to catch up with the 21st century.

- irq_create_identity mapping is just a variation on the above, with
irq==hwirq, although the way it is used is a gross hack in the SH
code that needs to go.

- irq_domain_add_legacy_isa is, as the names shows, a variation on
irq_domain_add_legacy with a reservation of 16 interrupts. This is
only used in the PPC code.

The patches address all of the above, touching some of the ARM, PPC,
and SH code that is affected. Another couple of patches address a MIPS
platform that could use the generic code, and clean some of the
comments in the irqdomain code.

Unless anyone shouts, I'd like to take this into 5.13, as it is the
basis of some further (and deeper) changes in the way irqdomains work.

M.

Marc Zyngier (9):
irqdomain: Reimplement irq_linear_revmap() with irq_find_mapping()
ARM: PXA: Kill use of irq_create_strict_mappings()
irqchip/jcore-aic: Kill use of irq_create_strict_mappings()
sh: intc: Drop the use of irq_create_identity_mapping()
irqdomain: Kill
irq_create_strict_mappings()/irq_create_identity_mapping()
mips: netlogic: Use irq_domain_simple_ops for XLP PIC
irqdomain: Drop references to recusive irqdomain setup
powerpc: Convert irq_domain_add_legacy_isa use to
irq_domain_add_legacy
irqdomain: Kill irq_domain_add_legacy_isa

Documentation/core-api/irq/irq-domain.rst | 1 -
arch/arm/mach-pxa/pxa_cplds_irqs.c | 24 +++++------
arch/mips/netlogic/common/irq.c | 6 +--
arch/powerpc/include/asm/irq.h | 4 +-
arch/powerpc/platforms/ps3/interrupt.c | 4 +-
arch/powerpc/sysdev/i8259.c | 3 +-
arch/powerpc/sysdev/mpic.c | 2 +-
arch/powerpc/sysdev/tsi108_pci.c | 3 +-
arch/powerpc/sysdev/xics/xics-common.c | 2 +-
drivers/irqchip/irq-jcore-aic.c | 4 +-
drivers/sh/intc/core.c | 50 ++++++++++-------------
include/linux/irqdomain.h | 42 ++++---------------
kernel/irq/irqdomain.c | 49 +++-------------------
13 files changed, 59 insertions(+), 135 deletions(-)

--
2.29.2

\
 
 \ /
  Last update: 2021-04-06 11:38    [W:0.156 / U:2.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site