[lkml]   [2021]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH 0/2] drm/msm: Smooth out ringbuffer-full handling
From: Rob Clark <>

With some recent userspace work to allow more rendering to be merged
into a single SUBMIT ioctl, I realized we have some sharp edges around
running out of free ringbuffer space.

1) Currently we only flush once all the cmds (or rather IBs to the cmd
buffer) are written into the ringbuffer. Which places a restriction
that the submit must fit in the rb. Which means slightly less than
2k cmds per submit, after accounting for some of the other packets
2) Currently, for devices that use RPTR shadow, we only write the
CP_WHERE_AM_I packet at the end of the submit, so we aren't seeing
partial progress that the GPU is making chewing through previous
large submits
3) We spin for up to 1sec waiting for rb space, and then give up and
proceed to overwrite the packets that that CP is currently chewing
on.. which goes badly. If userspace is submitting >1sec of work
per submit ioctl, this means we spin for a long time, and then
corrupt the rb anyways.

This patchset doesn't completely address #1. And in general we don't
want to be uninteruptably blocking for so much time.. but this will
require some more extensive changes.

What it does do is address #2 by periodically emitting a CP_WHERE_AM_I,
and #3 by adding detection and error handling for rb overflow, returning
-ENOSPC when that happens.

Rob Clark (2):
drm/msm: Handle ringbuffer overflow
drm/msm: Periodically update RPTR shadow

drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 32 ++++++++++++++++++++----
drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 30 +++++++++++++++++-----
drivers/gpu/drm/msm/adreno/adreno_gpu.c | 24 +++++++++++++++++-
drivers/gpu/drm/msm/msm_gem_submit.c | 7 +++++-
drivers/gpu/drm/msm/msm_gpu.c | 33 +++++++++++++++++++++++--
drivers/gpu/drm/msm/msm_gpu.h | 2 +-
drivers/gpu/drm/msm/msm_ringbuffer.h | 5 ++++
7 files changed, 117 insertions(+), 16 deletions(-)


 \ /
  Last update: 2021-04-28 21:34    [W:2.284 / U:0.712 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site