Messages in this thread | | | Date | Sun, 25 Apr 2021 19:36:12 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [PATCH 06/78] media: renesas-ceu: fix pm_runtime_get_sync() usage count (fwd) |
| |
Should there be an unlock before line 1104?
thanks, julia
---------- Forwarded message ---------- Date: Sun, 25 Apr 2021 06:51:17 +0800 From: kernel test robot <lkp@intel.com> To: kbuild@lists.01.org Cc: lkp@intel.com, Julia Lawall <julia.lawall@lip6.fr> Subject: Re: [PATCH 06/78] media: renesas-ceu: fix pm_runtime_get_sync() usage count
CC: kbuild-all@lists.01.org In-Reply-To: <29ba3fafde4d2643fae49789e6b378d6b1fd51f5.1619191723.git.mchehab+huawei@kernel.org> References: <29ba3fafde4d2643fae49789e6b378d6b1fd51f5.1619191723.git.mchehab+huawei@kernel.org> TO: Mauro Carvalho Chehab <mchehab@kernel.org> CC: linux-media@vger.kernel.org CC: linuxarm@huawei.com CC: mauro.chehab@huawei.com CC: Mauro Carvalho Chehab <mchehab@kernel.org> CC: linux-media@vger.kernel.org CC: Jacopo Mondi <jacopo@jmondi.org> CC: linux-kernel@vger.kernel.org CC: linux-renesas-soc@vger.kernel.org
Hi Mauro,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master] [also build test WARNING on rockchip/for-next tegra/for-next v5.12-rc8 next-20210423] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/media-use-pm_runtime_resume_and_get-instead-of-pm_runtime_get_sync/20210424-145029 base: git://linuxtv.org/media_tree.git master :::::: branch date: 16 hours ago :::::: commit date: 16 hours ago config: riscv-allyesconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
cocci warnings: (new ones prefixed by >>) >> drivers/media/platform/renesas-ceu.c:1104:2-8: preceding lock on line 1100
vim +1104 drivers/media/platform/renesas-ceu.c
32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1090 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1091 static int ceu_open(struct file *file) 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1092 { 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1093 struct ceu_device *ceudev = video_drvdata(file); 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1094 int ret; 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1095 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1096 ret = v4l2_fh_open(file); 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1097 if (ret) 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1098 return ret; 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1099 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 @1100 mutex_lock(&ceudev->mlock); 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1101 /* Causes soft-reset and sensor power on on first open */ 4825ba42eb8d20 Mauro Carvalho Chehab 2021-04-24 1102 ret = pm_runtime_resume_and_get(ceudev->dev); 4825ba42eb8d20 Mauro Carvalho Chehab 2021-04-24 1103 if (ret < 0) 4825ba42eb8d20 Mauro Carvalho Chehab 2021-04-24 @1104 return ret; 4825ba42eb8d20 Mauro Carvalho Chehab 2021-04-24 1105 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1106 mutex_unlock(&ceudev->mlock); 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1107 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1108 return 0; 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1109 } 32e5a70dc8f4e9 Jacopo Mondi 2018-02-22 1110
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org[unhandled content-type:application/gzip] | |