lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] lib/math/test_div64: Fix error message formatting
Align the expected result with one actually produced for easier visual 
comparison; this has to take into account what the format specifiers
will actually produce rather than the characters they consist of. E.g.:

test_div64: ERROR: 10000000ab275080 / 00000009 => 01c71c71da20d00e,00000002
test_div64: ERROR: expected value => 0000000013045e47,00000001

(with a failure induced by setting bit #60 of the divident).

Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
---
lib/math/test_div64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-3maxp-div64/lib/math/test_div64.c
===================================================================
--- linux-3maxp-div64.orig/lib/math/test_div64.c
+++ linux-3maxp-div64/lib/math/test_div64.c
@@ -170,7 +170,7 @@ static inline bool test_div64_verify(u64
if (!test_div64_verify(quotient, remainder, i, j)) { \
pr_err("ERROR: %016llx / %08x => %016llx,%08x\n", \
divident, divisor, quotient, remainder); \
- pr_err("ERROR: expected value=> %016llx,%08x\n", \
+ pr_err("ERROR: expected value => %016llx,%08x\n",\
test_div64_results[i][j].quotient, \
test_div64_results[i][j].remainder); \
result = false; \
\
 
 \ /
  Last update: 2021-04-21 15:28    [W:0.019 / U:0.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site