lkml.org 
[lkml]   [2021]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] Input: atkbd - simplify atkbd_show_force_release()
Date
We can just include the newline in the format string, and scnprintf()
guarantees nul-termination. These days, sysfs_emit() is
preferred in sysfs ->show methods, so switch to that.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/input/keyboard/atkbd.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
index edc613efc158..b146a3ec631a 100644
--- a/drivers/input/keyboard/atkbd.c
+++ b/drivers/input/keyboard/atkbd.c
@@ -1492,13 +1492,8 @@ static ssize_t atkbd_set_extra(struct atkbd *atkbd, const char *buf, size_t coun

static ssize_t atkbd_show_force_release(struct atkbd *atkbd, char *buf)
{
- size_t len = scnprintf(buf, PAGE_SIZE - 1, "%*pbl",
- ATKBD_KEYMAP_SIZE, atkbd->force_release_mask);
-
- buf[len++] = '\n';
- buf[len] = '\0';
-
- return len;
+ return sysfs_emit(buf, "%*pbl\n",
+ ATKBD_KEYMAP_SIZE, atkbd->force_release_mask);
}

static ssize_t atkbd_set_force_release(struct atkbd *atkbd,
--
2.29.2
\
 
 \ /
  Last update: 2021-04-21 22:20    [W:0.041 / U:1.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site