Messages in this thread | | | From | Alexander Shishkin <> | Subject | Re: [PATCH 2/7] stm class: Replace uuid_t with plain u8 uuid[16] | Date | Thu, 15 Apr 2021 12:20:14 +0300 |
| |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> On Wed, Apr 14, 2021 at 10:14:34PM +0300, Alexander Shishkin wrote: >> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes: >> >> >> Using raw buffer APIs against uuid_t / guid_t. >> > >> > So you want to do that, or you do not want to do that? Totally >> > confused, >> >> My understanding is that: >> 1) generate_random_uuid() use is allegedly bad even though it's in their >> header, >> 2) poking directly at the byte array inside uuid_t is bad, even though, >> again, header. >> >> It is, indeed, not ideal. >> >> If agreeable, I'll update this patch to the below and respin the whole >> series. > > You are showing that Andy wrote this, when you are the one that did :(
That's intentional, it's Andy's patch. In fact, it was probably me who insisted on the open-coded-byte-array version, in an offline conversation some time ago. I'd like to keep his name on it if that's ok. I've re-sent it [1] as a standalone patch.
> Anyway, I've dropped this single patch from the series and applied the > rest. Feel free to send this patch as a stand-alone one once you have > the authorship issues sorted out.
Thank you!
[1] https://lore.kernel.org/lkml/20210415091555.88085-1-alexander.shishkin@linux.intel.com/
Regards, -- Alex
| |