Messages in this thread Patch in this message | | | From | Ye Bin <> | Subject | [RFC] ext4: Fix fs can't panic when abort by user | Date | Thu, 1 Apr 2021 16:19:03 +0800 |
| |
Test steps: 1. mount /dev/sda -o errors=panic test 2. mount /dev/sda -o remount,ro test 3. mount /dev/sda -o remount,abort test
Before 014c9caa29d3 not been merged there will trigger panic. But 014c9caa29d3 change this behavior.
Fixes: 014c9caa29d3 ("ext4: make ext4_abort() use __ext4_error()") Signed-off-by: Ye Bin <yebin10@huawei.com> --- fs/ext4/super.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index b9693680463a..acb75dc396f8 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -667,9 +667,6 @@ static void ext4_handle_error(struct super_block *sb, bool force_ro, int error, ext4_commit_super(sb); } - if (sb_rdonly(sb) || continue_fs) - return; - /* * We force ERRORS_RO behavior when system is rebooting. Otherwise we * could panic during 'reboot -f' as the underlying device got already @@ -679,6 +676,10 @@ static void ext4_handle_error(struct super_block *sb, bool force_ro, int error, panic("EXT4-fs (device %s): panic forced after error\n", sb->s_id); } + + if (sb_rdonly(sb) || continue_fs) + return; + ext4_msg(sb, KERN_CRIT, "Remounting filesystem read-only"); /* * Make sure updated value of ->s_mount_flags will be visible before -- 2.25.4
| |