Messages in this thread Patch in this message | | | From | "Matthew Wilcox (Oracle)" <> | Subject | [PATCH] fb_defio: Use __set_page_dirty_no_writeback | Date | Sat, 6 Mar 2021 21:15:16 +0000 |
| |
The home-grown set_page_dirty() implementation had the wrong return value. Use __set_page_dirty_no_writeback() like other in-memory implementations.
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> --- drivers/video/fbdev/core/fb_defio.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/video/fbdev/core/fb_defio.c b/drivers/video/fbdev/core/fb_defio.c index a591d291b231..35021265e294 100644 --- a/drivers/video/fbdev/core/fb_defio.c +++ b/drivers/video/fbdev/core/fb_defio.c @@ -151,15 +151,8 @@ static const struct vm_operations_struct fb_deferred_io_vm_ops = { .page_mkwrite = fb_deferred_io_mkwrite, }; -static int fb_deferred_io_set_page_dirty(struct page *page) -{ - if (!PageDirty(page)) - SetPageDirty(page); - return 0; -} - static const struct address_space_operations fb_deferred_io_aops = { - .set_page_dirty = fb_deferred_io_set_page_dirty, + .set_page_dirty = __set_page_dirty_no_writeback, }; int fb_deferred_io_mmap(struct fb_info *info, struct vm_area_struct *vma) -- 2.30.0
| |