Messages in this thread | | | From | Song Liu <> | Subject | Re: [PATCH 2/3] perf tool: Enable warnings when compiling BPF programs | Date | Sat, 6 Mar 2021 19:33:25 +0000 |
| |
> On Mar 6, 2021, at 12:08 AM, Ian Rogers <irogers@google.com> wrote: > > Add -Wall -Werror when compiling BPF skeletons. > > Signed-off-by: Ian Rogers <irogers@google.com>
Acked-by: Song Liu <songliubraving@fb.com>
> --- > tools/perf/Makefile.perf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/Makefile.perf b/tools/perf/Makefile.perf > index 5345ac70cd83..f43d2551f3de 100644 > --- a/tools/perf/Makefile.perf > +++ b/tools/perf/Makefile.perf > @@ -1029,7 +1029,7 @@ $(BPFTOOL): | $(SKEL_TMP_OUT) > OUTPUT=$(SKEL_TMP_OUT)/ bootstrap > > $(SKEL_TMP_OUT)/%.bpf.o: util/bpf_skel/%.bpf.c $(LIBBPF) | $(SKEL_TMP_OUT) > - $(QUIET_CLANG)$(CLANG) -g -O2 -target bpf $(BPF_INCLUDE) \ > + $(QUIET_CLANG)$(CLANG) -g -O2 -target bpf -Wall -Werror $(BPF_INCLUDE) \ > -c $(filter util/bpf_skel/%.bpf.c,$^) -o $@ && $(LLVM_STRIP) -g $@ > > $(SKEL_OUT)/%.skel.h: $(SKEL_TMP_OUT)/%.bpf.o | $(BPFTOOL) > -- > 2.30.1.766.gb4fecdf3b7-goog >
| |