lkml.org 
[lkml]   [2021]   [Mar]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/3] perf skel: Remove some unused variables.
Date


> On Mar 6, 2021, at 12:08 AM, Ian Rogers <irogers@google.com> wrote:
>
> Fixes -Wall warnings.
>
> Signed-off-by: Ian Rogers <irogers@google.com>

Acked-by: Song Liu <songliubraving@fb.com>

Thanks for the clean up!

> ---
> tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c b/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c
> index c7cec92d0236..ab12b4c4ece2 100644
> --- a/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c
> +++ b/tools/perf/util/bpf_skel/bpf_prog_profiler.bpf.c
> @@ -52,7 +52,7 @@ int BPF_PROG(fentry_XXX)
> static inline void
> fexit_update_maps(struct bpf_perf_event_value *after)
> {
> - struct bpf_perf_event_value *before, diff, *accum;
> + struct bpf_perf_event_value *before, diff;
> __u32 zero = 0;
>
> before = bpf_map_lookup_elem(&fentry_readings, &zero);
> @@ -78,7 +78,6 @@ int BPF_PROG(fexit_XXX)
> {
> struct bpf_perf_event_value reading;
> __u32 cpu = bpf_get_smp_processor_id();
> - __u32 one = 1, zero = 0;
> int err;
>
> /* read all events before updating the maps, to reduce error */
> --
> 2.30.1.766.gb4fecdf3b7-goog
>

\
 
 \ /
  Last update: 2021-03-06 20:35    [W:0.077 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site