lkml.org 
[lkml]   [2021]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 RESEND 2/2] ARM: dts: Add board-specific compatible string to npcm750-evb devicetree
On Thu, Mar 04, 2021 at 05:21:36PM +0200, Tomer Maimon wrote:
> Hi Jonathan,
>
> Thanks a lot for sending the patch,
>
> I think that when it related to the SoC EVB it can stay with the
> genral compatible name nuvoton,npcm750
>
> you can see it also in,
> https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/aspeed-ast2500-evb.dts#L8

To make the single compatible string match the DT binding, I'll have to
write the binding a little differently. I wrote it like this:

compatible:
oneOf:
- description: NPCM750 based boards
items:
- enum:
- nuvoton,npcm750-evb # NPCM750 evaluation board
- const: nuvoton,npcm750


I guess I could do something like this:

compatible:
oneOf:
- description: NPCM750 development board
const: nuvoton,npcm750


And later add this part, when needed:

- description: NPCM750 based boards
items:
- enum:
- vendor,foo-bar-bmc
- const: nuvoton,npcm750


What do you think?


Thanks,
Jonathan Neuschäfer


> On Wed, 3 Mar 2021 at 17:47, Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> wrote:
[...]
> > / {
> > model = "Nuvoton npcm750 Development Board (Device Tree)";
> > - compatible = "nuvoton,npcm750";
> > + compatible = "nuvoton,npcm750-evb", "nuvoton,npcm750";
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-03-04 16:46    [W:0.069 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site