lkml.org 
[lkml]   [2021]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 RESEND 2/2] ARM: dts: Add board-specific compatible string to npcm750-evb devicetree
Hi Tomer,

your in-line reply got lost in the "> " lines, but I found it anyway.

On Thu, Mar 11, 2021 at 04:11:59PM +0200, Tomer Maimon wrote:
> Hi Jonathan,
>
> Thanks a lot for your effort!
>
> On Thu, 4 Mar 2021 at 17:42, Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> wrote:
>
> > On Thu, Mar 04, 2021 at 05:21:36PM +0200, Tomer Maimon wrote:
> > > Hi Jonathan,
> > >
> > > Thanks a lot for sending the patch,
> > >
> > > I think that when it related to the SoC EVB it can stay with the
> > > genral compatible name nuvoton,npcm750
> > >
> > > you can see it also in,
> > > https://github.com/torvalds/linux/blob/master/arch/arm/boot/dts/aspeed-ast2500-evb.dts#L8
> >
> > To make the single compatible string match the DT binding, I'll have to
> > write the binding a little differently. I wrote it like this:
> >
> > compatible:
> > oneOf:
> > - description: NPCM750 based boards
> > items:
> > - enum:
> > - nuvoton,npcm750-evb # NPCM750 evaluation board
> > - const: nuvoton,npcm750
> >
>
> I think it should be like the exemple above

If I specify the devicetree binding like above (which I initially did),
it implies that the compatible line in nuvoton-npcm750-evb.dts should be

compatible = "nuvoton,npcm750-evb", "nuvoton,npcm750";

not

compatible = "nuvoton,npcm750";


This is why I suggested rewriting it like below:

> > compatible:
> > oneOf:
> > - description: NPCM750 development board
> > const: nuvoton,npcm750
> >
> > - description: NPCM750 based boards
> > items:
> > - enum:
> > - vendor,foo-bar-bmc
> > - const: nuvoton,npcm750


I will send this new approach as a patch in a few days.


Thanks,
Jonathan Neuschäfer
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2021-03-11 16:16    [W:0.213 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site