Messages in this thread Patch in this message | | | From | Colin King <> | Subject | [PATCH][next] netfilter: nf_log_bridge: Fix missing assignment of ret on a call to nf_log_register | Date | Wed, 31 Mar 2021 15:26:06 +0100 |
| |
From: Colin Ian King <colin.king@canonical.com>
Currently the call to nf_log_register is returning an error code that is not being assigned to ret and yet ret is being checked. Fix this by adding in the missing assignment.
Addresses-Coverity: ("Logically dead code") Fixes: 8d02e7da87a0 ("netfilter: nf_log_bridge: merge with nf_log_syslog") Signed-off-by: Colin Ian King <colin.king@canonical.com> --- net/netfilter/nf_log_syslog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/nf_log_syslog.c b/net/netfilter/nf_log_syslog.c index 025ab9c66d13..2518818ed479 100644 --- a/net/netfilter/nf_log_syslog.c +++ b/net/netfilter/nf_log_syslog.c @@ -1042,7 +1042,7 @@ static int __init nf_log_syslog_init(void) if (ret < 0) goto err4; - nf_log_register(NFPROTO_BRIDGE, &nf_bridge_logger); + ret = nf_log_register(NFPROTO_BRIDGE, &nf_bridge_logger); if (ret < 0) goto err5; -- 2.30.2
| |