Messages in this thread | | | From | Andy Shevchenko <> | Date | Wed, 31 Mar 2021 17:10:39 +0300 | Subject | Re: [PATCH 2/3] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set |
| |
On Wed, Mar 31, 2021 at 4:24 PM Matthias Schiffer <matthias.schiffer@ew.tq-group.com> wrote: > On Wed, 2021-03-31 at 15:35 +0300, Andy Shevchenko wrote: > > On Wed, Mar 31, 2021 at 2:39 PM Matthias Schiffer > > <matthias.schiffer@ew.tq-group.com> wrote:
...
> > > + tqmx_gpio_resources[0].flags = 0; > > > > Please set IORESOURCE_DISABLED flag in the initial structure instead. > > Is there any documentation for the correct usage of this flag? I think > I tried IORESOURCE_DISABLED originally, but it didn't have any effect > (platform_get_irq() ignored the flag and returned the resource > anyways). I might misremember though, I originally wrote the series > some time ago.
It seems this flag is used solely for ACPI / PNP resources... Hmm... I dunno how platorm_get_irq*() should respect this flag. You see, that in the ACPI branch it has been checked there.
-- With Best Regards, Andy Shevchenko
| |