Messages in this thread | | | Subject | Re: [PATCH 2/3] mfd: tqmx86: clear GPIO IRQ resource when no IRQ is set | From | Matthias Schiffer <> | Date | Wed, 31 Mar 2021 15:24:22 +0200 |
| |
On Wed, 2021-03-31 at 15:35 +0300, Andy Shevchenko wrote: > On Wed, Mar 31, 2021 at 2:39 PM Matthias Schiffer > <matthias.schiffer@ew.tq-group.com> wrote: > > > > The driver was registering IRQ 0 when no IRQ was set. This leads to > > warnings with newer kernels. > > > > Clear the resource flags, so no resource is registered at all in this > > case. > > ... > > > /* Assumes the IRQ resource is first. */ > > tqmx_gpio_resources[0].start = gpio_irq; > > + } else { > > + tqmx_gpio_resources[0].flags = 0; > > Please set IORESOURCE_DISABLED flag in the initial structure instead.
Is there any documentation for the correct usage of this flag? I think I tried IORESOURCE_DISABLED originally, but it didn't have any effect (platform_get_irq() ignored the flag and returned the resource anyways). I might misremember though, I originally wrote the series some time ago.
> > > } > >
| |