Messages in this thread Patch in this message | | | From | Chunyan Zhang <> | Subject | [PATCH] iommu: sprd: Fix parameter type warning | Date | Wed, 31 Mar 2021 11:16:45 +0800 |
| |
From: Chunyan Zhang <chunyan.zhang@unisoc.com>
The second parameter of clk_get_optional() is "const char *", so use NULL instead of integer 0 to fix a sparse warning like:
">> drivers/iommu/sprd-iommu.c:456:42: sparse: sparse: Using plain integer as NULL pointer"
Also this patch changes to use the resource-managed variant of clk_get_optional(), then there's no need to add clk_put() which is missed in the current driver.
Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> --- drivers/iommu/sprd-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/sprd-iommu.c b/drivers/iommu/sprd-iommu.c index 7100ed17dcce..371d5715cbc9 100644 --- a/drivers/iommu/sprd-iommu.c +++ b/drivers/iommu/sprd-iommu.c @@ -453,7 +453,7 @@ static int sprd_iommu_clk_enable(struct sprd_iommu_device *sdev) { struct clk *eb; - eb = clk_get_optional(sdev->dev, 0); + eb = devm_clk_get_optional(sdev->dev, NULL); if (!eb) return 0; -- 2.25.1
| |