Messages in this thread | | | Subject | [PATCH v2 0/4] cxl/mem: Fix memdev device setup | From | Dan Williams <> | Date | Mon, 29 Mar 2021 19:47:39 -0700 |
| |
Changes since v1: [1] - switch percpu_ref to srcu (Jason) - introduce cxl_memdev_alloc() (Jason)
[1]: http://lore.kernel.org/r/161661970558.1721612.10441826898835759137.stgit@dwillia2-desk3.amr.corp.intel.com
---
A small collection of fixes mostly inspired by Jason's recognition of dev_set_name() error handling mistakes on other driver review.
dev_set_name() can fail and although device_add() might catch it that's not a reliable assumption. While fixing that I noticed that the unwind handling for cdev_device_add() failures leaked the device name.
The sysfs_emit() fixup and unpublishing of device power management files are just sanity cleanups.
---
Dan Williams (4): cxl/mem: Use sysfs_emit() for attribute show routines cxl/mem: Fix synchronization mechanism for device removal vs ioctl operations cxl/mem: Do not rely on device_add() side effects for dev_set_name() failures cxl/mem: Disable cxl device power management
drivers/cxl/mem.c | 127 +++++++++++++++++++++++++++++++---------------------- 1 file changed, 75 insertions(+), 52 deletions(-)
base-commit: a38fd8748464831584a19438cbb3082b5a2dab15
| |