| Date | Thu, 25 Mar 2021 21:35:01 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v3 06/17] kthread: use WARN_ON_FUNCTION_MISMATCH |
| |
On Tue, Mar 23, 2021 at 01:39:35PM -0700, Sami Tolvanen wrote: > With CONFIG_CFI_CLANG, a callback function passed to > __kthread_queue_delayed_work from a module points to a jump table > entry defined in the module instead of the one used in the core > kernel, which breaks function address equality in this check: > > WARN_ON_ONCE(timer->function != ktead_delayed_work_timer_fn); > > Use WARN_ON_FUNCTION_MISMATCH() instead to disable the warning > when CFI and modules are both enabled. > > Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
|