lkml.org 
[lkml]   [2021]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 05/17] workqueue: use WARN_ON_FUNCTION_MISMATCH
    On Tue, Mar 23, 2021 at 01:39:34PM -0700, Sami Tolvanen wrote:
    > With CONFIG_CFI_CLANG, a callback function passed to
    > __queue_delayed_work from a module points to a jump table entry
    > defined in the module instead of the one used in the core kernel,
    > which breaks function address equality in this check:
    >
    > WARN_ON_ONCE(timer->function != delayed_work_timer_fn);
    >
    > Use WARN_ON_FUNCTION_MISMATCH() instead to disable the warning
    > when CFI and modules are both enabled.
    >
    > Signed-off-by: Sami Tolvanen <samitolvanen@google.com>

    Reviewed-by: Kees Cook <keescook@chromium.org>

    --
    Kees Cook

    \
     
     \ /
      Last update: 2021-03-26 05:35    [W:6.892 / U:0.124 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site