Messages in this thread | | | From | Syed Nayyar Waris <> | Date | Sat, 27 Mar 2021 03:42:37 +0530 | Subject | Re: [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value |
| |
On Fri, Mar 26, 2021 at 11:32 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Sat, Mar 6, 2021 at 4:08 PM Syed Nayyar Waris <syednwaris@gmail.com> wrote: > > > + bitmap_set_value(old, 64, state[0], 32, 0); > > + bitmap_set_value(old, 64, state[1], 32, 32); > > Isn't it effectively bitnap_from_arr32() ? > > > + bitmap_set_value(new, 64, state[0], 32, 0); > > + bitmap_set_value(new, 64, state[1], 32, 32); > > Ditto. > > -- > With Best Regards, > Andy Shevchenko
Hi Andy,
With bitmap_set_value() we are also specifying the offset (or start) position too. so that the remainder of the array remains unaffected. I think it would not be feasible to use bitmap_from/to_arr32() here.
Regards Syed Nayyar Waris
| |