Messages in this thread | | | Subject | Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver | From | Jie Deng <> | Date | Tue, 23 Mar 2021 16:33:30 +0800 |
| |
On 2021/3/23 15:27, Viresh Kumar wrote:
> On 23-03-21, 22:19, Jie Deng wrote: >> +static int __maybe_unused virtio_i2c_freeze(struct virtio_device *vdev) >> +{ >> + virtio_i2c_del_vqs(vdev); >> + return 0; >> +} >> + >> +static int __maybe_unused virtio_i2c_restore(struct virtio_device *vdev) >> +{ >> + return virtio_i2c_setup_vqs(vdev->priv); >> +} > Sorry for not looking at this earlier, but shouldn't we enclose the above two > within #ifdef CONFIG_PM_SLEEP instead and drop the __maybe_unused ?
I remembered I was suggested to use "__maybe_unused" instead of "#ifdef".
You may check this https://lore.kernel.org/patchwork/patch/732981/
The reason may be something like that.
| |