Messages in this thread | | | Date | Tue, 23 Mar 2021 12:57:04 +0530 | From | Viresh Kumar <> | Subject | Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver |
| |
On 23-03-21, 22:19, Jie Deng wrote: > +static int __maybe_unused virtio_i2c_freeze(struct virtio_device *vdev) > +{ > + virtio_i2c_del_vqs(vdev); > + return 0; > +} > + > +static int __maybe_unused virtio_i2c_restore(struct virtio_device *vdev) > +{ > + return virtio_i2c_setup_vqs(vdev->priv); > +}
Sorry for not looking at this earlier, but shouldn't we enclose the above two within #ifdef CONFIG_PM_SLEEP instead and drop the __maybe_unused ?
> + > +static struct virtio_driver virtio_i2c_driver = { > + .id_table = id_table, > + .probe = virtio_i2c_probe, > + .remove = virtio_i2c_remove, > + .driver = { > + .name = "i2c_virtio", > + }, > +#ifdef CONFIG_PM_SLEEP > + .freeze = virtio_i2c_freeze, > + .restore = virtio_i2c_restore, > +#endif > +};
-- viresh
| |