lkml.org 
[lkml]   [2021]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] mfd: sy7636a: Initial commit

Hi,


On Sun, 21 Mar 2021, Alistair Francis wrote:

> Initial support for the Silergy SY7636A Power Management chip.
>
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
> v3:
> - Address comments in V2
> - Drop regulator patches
>
> drivers/mfd/Kconfig | 10 ++
> drivers/mfd/Makefile | 1 +
> drivers/mfd/sy7636a.c | 246 ++++++++++++++++++++++++++++++++++++
> include/linux/mfd/sy7636a.h | 46 +++++++
> 4 files changed, 303 insertions(+)
> create mode 100644 drivers/mfd/sy7636a.c
> create mode 100644 include/linux/mfd/sy7636a.h
>
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index b74efa469e90..a285d11d5be3 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1351,6 +1351,16 @@ config MFD_SYSCON
> Select this option to enable accessing system control registers
> via regmap.
>
> +config MFD_SY7636A
> + tristate "Silergy SY7636A Power Management chip"
> + select MFD_CORE
> + select REGMAP_I2C
> + select REGMAP_IRQ
> + depends on I2C=y

So why is this driver tristate but depends on I2C=y?
That's a little confusing.

Thanks.

> + help
> + Select this option to enable support for the Silergy SY7636A
> + Power Management chip.

\
 
 \ /
  Last update: 2021-03-21 18:41    [W:0.022 / U:1.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site