Messages in this thread Patch in this message | | | From | Zhiqiang Liu <> | Subject | [PATCH] pci/hotplug: fix potential memory leak in disable_slot() | Date | Sun, 21 Mar 2021 23:51:41 +0800 |
| |
In disable_slot(), if we obtain desired PCI device successfully by calling pci_get_slot(), we should call pci_dev_put() to release its reference.
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> Signed-off-by: Feilong Lin <linfeilong@huawei.com> --- drivers/pci/hotplug/s390_pci_hpc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/hotplug/s390_pci_hpc.c b/drivers/pci/hotplug/s390_pci_hpc.c index c9e790c74051..999a34b6fd50 100644 --- a/drivers/pci/hotplug/s390_pci_hpc.c +++ b/drivers/pci/hotplug/s390_pci_hpc.c @@ -89,9 +89,11 @@ static int disable_slot(struct hotplug_slot *hotplug_slot) return -EIO;
pdev = pci_get_slot(zdev->zbus->bus, zdev->devfn); - if (pdev && pci_num_vf(pdev)) { + if (pdev) { + rc = pci_num_vf(pdev); pci_dev_put(pdev); - return -EBUSY; + if (rc) + return -EBUSY; }
zpci_remove_device(zdev); -- 2.19.1
| |