Messages in this thread Patch in this message | | | From | Zhiqiang Liu <> | Subject | [PATCH] pci: fix memory leak when virtio pci hotplug | Date | Sun, 21 Mar 2021 23:29:30 +0800 |
| |
From: Feilong Lin <linfeilong@huawei.com>
Repeated hot-plugging of pci devices for a virtual machine driven by virtio, we found that there is a leak in kmalloc-4k, which was confirmed as the memory of the pci_device structure. Then we found out that it was missing pci_dev_put() after pci_get_slot() in enable_slot() of acpiphp_glue.c.
Signed-off-by: Feilong Lin <linfeilong@huawei.com> Reviewed-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> --- drivers/pci/hotplug/acpiphp_glue.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c index 3365c93abf0e..f031302ad401 100644 --- a/drivers/pci/hotplug/acpiphp_glue.c +++ b/drivers/pci/hotplug/acpiphp_glue.c @@ -533,6 +533,7 @@ static void enable_slot(struct acpiphp_slot *slot, bool bridge) slot->flags &= ~SLOT_ENABLED; continue; } + pci_dev_put(dev); } }
-- 2.19.1
| |