Messages in this thread | | | Subject | Re: [PATCH] staging: comedi: replace slash in name | From | Ian Abbott <> | Date | Tue, 16 Mar 2021 10:37:47 +0000 |
| |
On 15/03/2021 20:00, Tong Zhang wrote: > Thanks Ian, > I have submitted a v2 patch based on your suggestions. > Thanks, > - Tong
Thanks. I think the only other Comedi driver with the same problem is "drivers/staging/comedi/drivers/das800.c". It passes dev->board_name as the name argument of request_irq(), but that is "cio-das802/16" for one of the boards supported by the driver.
> On Mon, Mar 15, 2021 at 6:48 AM Ian Abbott <abbotti@mev.co.uk> wrote: >> >> On 15/03/2021 10:44, Ian Abbott wrote: >>> On 14/03/2021 03:57, Tong Zhang wrote: >>>> request_irq() wont accept a name which contains slash so we need to >>>> repalce it with something else -- otherwise it will trigger a warning >>>> and the entry in /proc/irq/ will not be created >>>> >>>> [ 1.565966] name 'pci-das6402/16' >>>> [ 1.566149] WARNING: CPU: 0 PID: 184 at fs/proc/generic.c:180 __xlate_proc_name+0x93/0xb0 >>>> [ 1.568923] RIP: 0010:__xlate_proc_name+0x93/0xb0 >>>> [ 1.574200] Call Trace: >>>> [ 1.574722] proc_mkdir+0x18/0x20 >>>> [ 1.576629] request_threaded_irq+0xfe/0x160 >>>> [ 1.576859] auto_attach+0x60a/0xc40 [cb_pcidas64] >>>> >>>> Signed-off-by: Tong Zhang <ztong0001@gmail.com> >> [snip] >>> Userspace applications can use these strings to determine the board >>> type, so changing the strings would break those applications. >>> >>> I suggest passing the comedi driver name "cb_pcidas" to request_irq() >>> for now. >> >> Oops, I meant "cb_pcidas64". But you could reach that via >> dev->driver->driver_name if you want (where dev is the struct >> comedi_device * parameter).
-- -=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company )=- -=( registered in England & Wales. Regd. number: 02862268. )=- -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=- -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
| |