Messages in this thread | | | Subject | Re: [PATCH] staging: comedi: das800: fix request_irq() warn | From | Ian Abbott <> | Date | Wed, 17 Mar 2021 12:48:50 +0000 |
| |
On 16/03/2021 22:42, Tong Zhang wrote: > request_irq() wont accept a name which contains slash so we need to > repalce it with something else -- otherwise it will trigger a warning > and the entry in /proc/irq/ will not be created > since the .name might be used by userspace and we don't want to break > userspace, so we are changing the parameters passed to request_irq() > > Suggested-by: Ian Abbott <abbotti@mev.co.uk> > Signed-off-by: Tong Zhang <ztong0001@gmail.com> > --- > drivers/staging/comedi/drivers/das800.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/comedi/drivers/das800.c b/drivers/staging/comedi/drivers/das800.c > index 2881808d6606..bc08324f422f 100644 > --- a/drivers/staging/comedi/drivers/das800.c > +++ b/drivers/staging/comedi/drivers/das800.c > @@ -668,7 +668,7 @@ static int das800_attach(struct comedi_device *dev, struct comedi_devconfig *it) > dev->board_name = board->name; > > if (irq > 1 && irq <= 7) { > - ret = request_irq(irq, das800_interrupt, 0, dev->board_name, > + ret = request_irq(irq, das800_interrupt, 0, "das800", > dev); > if (ret == 0) > dev->irq = irq; >
Looks good (apart from the minor spelling niggle spotted by Dan Carpenter), thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
-- -=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company )=- -=( registered in England & Wales. Regd. number: 02862268. )=- -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=- -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
| |