| Date | Thu, 11 Mar 2021 18:45:27 -0800 | From | Kees Cook <> | Subject | Re: [PATCH 09/17] lib/list_sort: fix function type mismatches |
| |
On Thu, Mar 11, 2021 at 04:49:11PM -0800, Sami Tolvanen wrote: > Casting the comparison function to a different type trips indirect > call Control-Flow Integrity (CFI) checking. Remove the additional > consts from cmp_func, and the now unneeded casts. > > Fixes: 043b3f7b6388 ("lib/list_sort: simplify and remove MAX_LIST_LENGTH_BITS") > Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
|