| Date | Thu, 11 Mar 2021 18:45:09 -0800 | From | Kees Cook <> | Subject | Re: [PATCH 07/17] kallsyms: cfi: strip hashes from static functions |
| |
On Thu, Mar 11, 2021 at 04:49:09PM -0800, Sami Tolvanen wrote: > With CONFIG_CFI_CLANG and ThinLTO, Clang appends a hash to the names > of all static functions not marked __used. This can break userspace > tools that don't expect the function name to change, so strip out the > hash from the output. > > Suggested-by: Jack Pham <jackp@codeaurora.org> > Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
(Is it possible we could end up with symbol name collisions? ... though I guess we would have had collisions before?)
Reviewed-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
|