lkml.org 
[lkml]   [2021]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 0/6] uvcvideo: Fix v4l2-compliance errors
Date
In my computer I am getting this output for

v4l2-compliance -m /dev/media0 -a -f
Total for uvcvideo device /dev/media0: 8, Succeeded: 6, Failed: 2, Warnings: 0
Total for uvcvideo device /dev/video0: 54, Succeeded: 50, Failed: 4, Warnings: 2
Total for uvcvideo device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0
Grand Total for uvcvideo device /dev/media0: 108, Succeeded: 102,
Failed: 6, Warnings: 2

After fixing all of them we go down to:

Total for uvcvideo device /dev/media0: 8, Succeeded: 8, Failed: 0, Warnings: 0
Total for uvcvideo device /dev/video0: 54, Succeeded: 54, Failed: 0, Warnings: 9
Total for uvcvideo device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0
Grand Total for uvcvideo device /dev/media0: 108, Succeeded: 108,
Failed: 0, Warnings: 9

We are still not compliant with v4l2-compliance -s:

Streaming ioctls:
test read/write: OK (Not Supported)
test blocking wait: OK
fail: v4l2-test-buffers.cpp(1265):
node->streamon(q.g_type()) != EINVAL
test MMAP (no poll): FAIL
fail: v4l2-test-buffers.cpp(1265):
node->streamon(q.g_type()) != EINVAL
test MMAP (select): FAIL
fail: v4l2-test-buffers.cpp(1265):
node->streamon(q.g_type()) != EINVAL
test MMAP (epoll): FAIL

But fixing that will probably require a lot of changes in the driver
that are already implemented in the vb2 helpers. It is better to
continue Hans work on that:
https://git.linuxtv.org/hverkuil/media_tree.git/commit/?h=uvc-4.19&id=a6a0a05f643521d29a4c1e551b0be73ce66b7108

Changelog v2 (Thanks to Hans and Laurent)

- Reimplement the CTRL_CLASS as a patch on queryctl
- Do not return -EIO for case 8
- Handle request bug and which_def multiclass in core

Ricardo Ribalda (6):
media: v4l2-ioctl: Fix check_ext_ctrls
media: uvcvideo: Set capability in s_param
media: uvcvideo: Return -EIO for control errors
media: uvcvideo: set error_idx to count on EACCESS
media: uvcvideo: Add support for V4L2_CTRL_TYPE_CTRL_CLASS
media: uvcvideo: Set a different name for the metadata entity

drivers/media/usb/uvc/uvc_ctrl.c | 90 ++++++++++++++++++++++++++++
drivers/media/usb/uvc/uvc_driver.c | 5 +-
drivers/media/usb/uvc/uvc_v4l2.c | 10 +++-
drivers/media/usb/uvc/uvc_video.c | 5 ++
drivers/media/usb/uvc/uvcvideo.h | 7 +++
drivers/media/v4l2-core/v4l2-ioctl.c | 4 +-
6 files changed, 116 insertions(+), 5 deletions(-)

--
2.31.0.rc2.261.g7f71774620-goog

\
 
 \ /
  Last update: 2021-03-11 23:21    [W:0.123 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site