Messages in this thread Patch in this message | | | From | Xiaofei Tan <> | Subject | [PATCH for-next 17/32] scsi: mac53c94: Replace spin_lock_irqsave with spin_lock in hard IRQ | Date | Sun, 7 Feb 2021 19:36:48 +0800 |
| |
It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context.
Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com> --- drivers/scsi/mac53c94.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/mac53c94.c b/drivers/scsi/mac53c94.c index 9e98977..ab59c79 100644 --- a/drivers/scsi/mac53c94.c +++ b/drivers/scsi/mac53c94.c @@ -182,12 +182,11 @@ static void mac53c94_start(struct fsc_state *state) static irqreturn_t do_mac53c94_interrupt(int irq, void *dev_id) { - unsigned long flags; struct Scsi_Host *dev = ((struct fsc_state *) dev_id)->current_req->device->host; - spin_lock_irqsave(dev->host_lock, flags); + spin_lock(dev->host_lock); mac53c94_interrupt(irq, dev_id); - spin_unlock_irqrestore(dev->host_lock, flags); + spin_unlock(dev->host_lock); return IRQ_HANDLED; } -- 2.8.1
| |