Messages in this thread Patch in this message | | | From | Xiaofei Tan <> | Subject | [PATCH for-next 12/32] scsi: gvp11: Replace spin_lock_irqsave with spin_lock in hard IRQ | Date | Sun, 7 Feb 2021 19:36:43 +0800 |
| |
It is redundant to do irqsave and irqrestore in hardIRQ context, where it has been in a irq-disabled context.
Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com> --- drivers/scsi/gvp11.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/gvp11.c b/drivers/scsi/gvp11.c index 727f8c8..f164a68 100644 --- a/drivers/scsi/gvp11.c +++ b/drivers/scsi/gvp11.c @@ -29,14 +29,13 @@ static irqreturn_t gvp11_intr(int irq, void *data) struct Scsi_Host *instance = data; struct gvp11_hostdata *hdata = shost_priv(instance); unsigned int status = hdata->regs->CNTR; - unsigned long flags; if (!(status & GVP11_DMAC_INT_PENDING)) return IRQ_NONE; - spin_lock_irqsave(instance->host_lock, flags); + spin_lock(instance->host_lock); wd33c93_intr(instance); - spin_unlock_irqrestore(instance->host_lock, flags); + spin_unlock(instance->host_lock); return IRQ_HANDLED; } -- 2.8.1
| |