Messages in this thread | | | Date | Tue, 2 Feb 2021 08:12:29 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v5 06/20] mfd: axp20x: Allow AXP chips without interrupt lines |
| |
On Wed, 27 Jan 2021, Andre Przywara wrote:
> Currently the AXP chip requires to have its IRQ line connected to some > interrupt controller, and will fail probing when this is not the case. > > On a new Allwinner SoC (H616) there is no NMI pin anymore, and at > least one board does not connect the AXP's IRQ pin to anything else, > so the interrupt functionality of the AXP chip is simply not available. > > Check whether the interrupt line number returned by the platform code is > valid, before trying to register the irqchip. If not, we skip this > registration, to avoid the driver to bail out completely. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > drivers/mfd/axp20x.c | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-)
For my own reference (apply this as-is to your sign-off block):
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |